[Woo POS] Modularization: move shared dependencies to shared frameworks in preparation for POS modularization #16159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… settings in the app layer.
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
jaclync
changed the title
staskus
approved these changes
Sep 24, 2025
|
|
||
| extension SiteAddress { | ||
| convenience init() { | ||
| self.init(siteSettings: ServiceLocator.selectedSiteSettings.siteSettings) |
Contributor
There was a problem hiding this comment.
Interesting, a good way to keep the backwards compatibility and avoid unnecessary changes after the refactoring 👍
Contributor
Author
There was a problem hiding this comment.
Yea, there are a few such usage in the app.
jaclync
deleted the
feat/WOOMOB-935-move-shared-dependencies-to-shared-frameworks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-935
Description
This PR moves shared dependencies from the app layer to appropriate framework layers in preparation for migrating Point of Sale (POS) code to a dedicated module WOOMOB-935. This restructuring enables access to code currently in the app layer when POS usage is moved to a separate module. The moves in this PR were pretty straightforward, while non-trivial moves like the
WaitingTimeTrackerwill be in a separate PR.Key Changes:
Moved to WooFoundation:
SafariViewandSafariSheetUI components - commonly used across POS and main app for web browsing. These two components are quite similar and probably worth consolidating, but it is out of scope of the POS modulairzationDateFormatterandDecimalextensions - utility extensions used in both POS and main appMoved to Yosemite:
SiteAddressmodel and functionality - business logic for store address handling needed by POS settingsCountryCode.readableCountryextension - country display logic required by POS and other features in the appYosemiteTestsApp Layer Updates:
SafariViewfromWooFoundationSiteAddressthat usesServiceLocatorfor app-layer compatibilitySteps to reproduce
Testing information
I tested the following:
Critical POS Flows to Test:
POS Settings Safari Views: Verify hardware documentation and help links open correctly in Safari
Store Address in POS: Confirm store location displays properly in POS settings
POS Eligibility: Test that country-based eligibility checks work correctly
Date/Currency Formatting: Verify proper formatting throughout POS flows
Main App Areas to Test:
In-Person Payments Settings: Test Safari links for card reader documentation
Store Settings: Verify site address functionality in main app settings
Date and currency display: Check formatting consistency across the app
RELEASE-NOTES.txtif necessary.